A one line change to solve a lot of problems installing plugins with nibs!

[johnno1962]

Hi, any chance you could you could merge this harmless one line change that solves the problems people have been having using Alcatraz:

#196
#202
johnno1962/GitDiff#31

This problem has been knocking about for a year now!!

Cheers

[johnno1962]

Don’t know whats up with your CI but I can’t believe it was this change!

[jurre]

No, CI has been broken for a while, I was actually planning on just ripping out the failing tests for now as they're clearly not adding any value at this point.

Thanks for the PR!

[jurre]

So we remove the existing build first and then re-fetch?

[johnno1962]

Thats about the size of it. I’ve tested and this really does resolve the problem. I can’t think of any new ones it would create.

[jurre]

I could kind of imagine the fetch failing and this uninstalling your plugin completely?

[johnno1962]

not if you delete only the build directory in Alcatraz's local git clone cache. Plugin will remain in ~/Library

[jurre]

👍 makes sense, thanks! @supermarin 🚢 ?

[supermarin]

Hey thanks @jurre and @johnno1962 !

I'm all in for merging it - but I believe it shouldn't live in ATZGit.
IMO it should live in plugin installer, and do it before git invocation.

How does that sound?

[johnno1962]

Fine by me. Thanks for picking this up! There are a few users who are going to thank you for it.

[orta]

this should be closed as #237 fixed it