Skip to content

perf: move custom-app js to load only on homepage #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

dslovinsky
Copy link
Collaborator

@dslovinsky dslovinsky commented Jul 31, 2025

Description

Currently we are loading the entire custom-app as a render-blocking script on all pages. This is inefficient since it's really just one component on the homepage. This moves it to a script tag on the homepage.

Related Issues

Changes Made

  • Move dist/output.js into a script tag on the homepage

Testing

  • I have tested these changes locally
  • I have run the validation scripts (pnpm run validate)
  • I have checked that the documentation builds correctly

@dslovinsky dslovinsky self-assigned this Jul 31, 2025
Copy link

github-actions bot commented Jul 31, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Aug 1, 2025, 6:56 AM

@github-actions github-actions bot temporarily deployed to docs-preview July 31, 2025 23:21 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview July 31, 2025 23:35 Destroyed
@dslovinsky dslovinsky marked this pull request as ready for review July 31, 2025 23:42
@dslovinsky dslovinsky requested a review from a team as a code owner July 31, 2025 23:42
@github-actions github-actions bot temporarily deployed to docs-preview July 31, 2025 23:42 Destroyed
Copy link
Contributor

@Brodan Brodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much winning

@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 00:44 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 01:04 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 02:39 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 02:58 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 03:21 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 03:38 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 03:48 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 04:18 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 04:45 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 05:11 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 05:24 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 06:42 Destroyed
@github-actions github-actions bot temporarily deployed to docs-preview August 1, 2025 06:55 Destroyed
@dslovinsky
Copy link
Collaborator Author

Having trouble solving for some edge-cases. Will discuss with Fern today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants