fix: placeholder quoting #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Originally strconv.Quote() was used to escape the string - Quote() escaped sequences such as \t - This was unwanted behavior - Now it's replaced with adding quotes manually
|
It's intentional, why is it unwanted behaviour? |
|
I assumed it's not intended since there does not seem to be a way to configure the default value to be If you have an app which configures Feel free to reject if it's indeed intended behavior. |
|
What is the actual content of |
|
|
|
I thing this PR is only trying to fix the symptoms of a tag's value not being properly unquoted. #348 should fix the underlying problem, therefore it should also resolve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #324
strconv.Quote()was used to escape the stringQuote()escaped sequences such as\t