fix: handle contents of tags properly by unquoting them when necessary #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! You can disable the linter with |
|
You are welcome! :) Ignored the linter and amended my commit, please try again. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far bare tags did not get unquoted, causing several problems. E.g., using backslashs in tags doesn't work as expected (I noticed when having a
defaulttag containing a RegExp).This also led to the issue described in #324.
The PR related to that issue (#330) is not really tackling the problem, it's just trying to fix the most obvious symptoms.
I added a test to ensure things are working.