Added support for OrderedDict validation, including as the return type #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested changes
Dec 7, 2016
| @@ -1,6 +1,7 @@ | |||
| import copy | |||
| import collections | |||
| from nose.tools import assert_equal, assert_raises, assert_true | |||
| import numpy | |||
There was a problem hiding this comment.
Please don't add numpy as a dependency, even for tests.
There was a problem hiding this comment.
fair point, I'll remove it
|
|
||
|
|
||
| def test_ordered_dict(): | ||
| if not hasattr(collections, 'OrderedDict'): |
There was a problem hiding this comment.
I'm fine with this (to answer your earlier question).
|
I think I've addressed your comments, but I'm not sure if I need to do anything else here. |
tusharmakkar08
requested changes
Dec 7, 2016
|
ok, squashed |
alecthomas
approved these changes
Dec 8, 2016
This was referenced Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #254, which I created earlier. The fix is pretty simple, sorry for the stupid formatting stuff, I can get rid of those changes as you desire.
One thing I thought was going to be an isuses was ensuring that
datais adict; however, that is already done in thevalidate_dictclosure (right?).... this is basically the same as a request I had before, except I added a conditional for Python2.6