Skip to content

Conversation

1yam
Copy link
Member

@1yam 1yam commented Sep 3, 2025

This PR add the handling of the news REMOVING and REMOVED status on sdk side.

Related ClickUp, GitHub or Jira tickets : ALEPH-573

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

This pull request makes a small adjustment to the message status validation logic in the get_stored_content method. The change allows messages with a status of either PROCESSED or REMOVING to pass validation, instead of only PROCESSED.

Notes

Sdk was already mostly handling it, only case i found is get_stored_content where message with removing status wouldn't let user get the stored content

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Sep 3, 2025
Copy link

github-actions bot commented Sep 3, 2025

Summary:
The PR contains a small change to the condition check in the get_stored_content function. The original condition checked if the status was not MessageStatus.PROCESSED, but now it checks if the status is not in the list [MessageStatus.PROCESSED, MessageStatus.REMOVING]. This change is unlikely to introduce bugs and is a straightforward improvement.

Highlight:

-            if status != MessageStatus.PROCESSED:
+            if status not in [MessageStatus.PROCESSED, MessageStatus.REMOVING]:

This change ensures that the function will now correctly identify messages that are not in the PROCESSED or REMOVING states, improving the robustness of the code. It is a simple and clear improvement that does not affect the overall logic of the function.

@nesitor nesitor force-pushed the 1yam-new-message-states branch from 8ca9159 to cd9995d Compare September 9, 2025 14:52
@1yam 1yam merged commit 5e3b927 into main Sep 12, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants