Fix: filter on crn list & port-forwarding

[1yam]

fix: #236

and fix an issue where crn wouldn't get fetch on the crn list due to filter

Also include the fix from this other PR spotted by @RezaRahemtola (#236):

When deleting an instance, the behavior for the ports-forwarding aggregate is different between the CLI and the UI:

• The CLI will update the aggregate to keep the value of the item hash to the existing values (example: https://explorer.aleph.cloud/address/ETH/0x238224C744F4b90b4494516e074D2676ECfC6803/message/AGGREGATE/4acb1fac2b28a54c73160c1cdde93c51bb4712be10ca34f934b209b832b2ebbb). This may be an unwanted behavior to investigate, but it is not the scope of this tentative fix.
• The UI will update the aggregate to set the value of the item hash to null (example: https://explorer.aleph.cloud/address/ETH/0x238224C744F4b90b4494516e074D2676ECfC6803/message/AGGREGATE/6bc45c2746f289e8fcf12fd44a0b41eae4c57ba408174cfaa63dda3ca002e2bb)

The problem is that the types in the SDK (and thus in the CLI) don't expect an item hash in the ports-forwarding aggregate to be null (as you can see, I just added the possibility in this PR).

This means that if a user deletes an instance in the UI, then the CLI won't function properly anymore, as it will throw Pydantic parsing errors when fetching the ports, for example when deleting an instance:

Unfortunately the fix is probably not as simple as adding this line:

• Adding the possibility of null ports may (well is according to the tests) break some stuff in the SDK / CLI so it should be done carefully
• Updating the UI to avoid setting null values is also out of the question imo, as it won't solve the issue for existing users (and after a quick look at the UI, it's using a generic part of the code to delete the ports so it would need a bit more than a single line change too)

[github-actions]

Summary:
This PR introduces a change to the AllForwarders type definition in the types.py file. The original type was RootModel[Dict[ItemHash, Ports]], and it has been updated to RootModel[Dict[ItemHash, Optional[Ports]]]. This change does not affect the functionality of the code but rather adds an optional type to the dictionary values, which is a common practice to handle cases where certain keys might not have associated Ports objects.

Highlight:

diff --git a/src/aleph/sdk/types.py b/src/aleph/sdk/types.py
index e76aedbc..b839a14b 100644
--- a/src/aleph/sdk/types.py
+++ b/src/aleph/sdk/types.py
@@ -309,7 +309,7 @@ class Ports(BaseModel):
     ports: Dict[int, PortFlags]
 
 
-AllForwarders = RootModel[Dict[ItemHash, Ports]]
+AllForwarders = RootModel[Dict[ItemHash, Optional[Ports]]]
 
 
 class DictLikeModel(BaseModel):

Explanation:
The change made in this PR is a straightforward type modification, adding an optional type to the dictionary values in the AllForwarders type definition. This does not introduce any new functionality or modify existing behavior. It is a refinement that improves type safety and ensures that the dictionary can handle cases where Ports might not be present for certain keys. This change is unlikely to introduce bugs and does not require a deep understanding of the codebase. Therefore, it is categorized as 'BLUE'.

[nesitor]

Suggested change

	required_tokens: Decimal
	payment_type: str
	required_tokens: Decimal
	cost: Optional[str]
	payment_type: str

I think that the cost field remains to stay here, as it's part of the response.