Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove urllib3 dependency #3402

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Remove urllib3 dependency #3402

merged 1 commit into from
Oct 9, 2023

Conversation

tillprochaska
Copy link
Contributor

I’m not really sure if we still need this as a direct dependency. Looking at the git history, it might have been added (years ago) in order to fix an incorrect dependency constraint in a dependency (probably the Elasticsearch Python client).

Removing it doesn’t seem to cause any problems and the latest version of urllib3<2 gets installed as a transitive dependency (because it is required by elasticsearch.

Copy link
Contributor

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this. I'm on board with us not pinning to a < 2 version, but I feel that if we still directly call urllib from our code we should have it as an explicit dependency and not rely on it being transitively brought in. Shall we try to bump it to the latest version?

@tillprochaska
Copy link
Contributor Author

We're not actually loading urllib though, just setting the log level, right?

But let me check if we do need to set the log level explicitly or if we can set it for the ES client directly in some way.

@stchris
Copy link
Contributor

stchris commented Oct 9, 2023

@tillprochaska sorry, I was confused by the import. You are right, we are not using this directly so it can go!

@tillprochaska tillprochaska merged commit f3d16ff into develop Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants