Completely remove network diagram embeds feature #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost 1.5 years ago we have disabled the UI option to create new embeds (see 0d69cad). Back then, we decided to hide the UI in the first step, but keep the code in place, just in case we needed to bring back the feature in case more users were relying on it than expected. We are now ready to entirely remove all code related to this feature. As a follow-up to this, we should also remove the `publish_file` method in servicelayer.
tillprochaska
force-pushed
the
remove-diagram-embeds
branch
from
2b521c8
to
b131c2d
Compare
catileptic
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost 1.5 years ago we have disabled the UI option to create new embeds (see 0d69cad). Back then, we decided to hide the UI in the first step, but keep the code in place, just in case we needed to bring back the feature in case more users were relying on it than expected.
We are now ready to entirely remove all code related to this feature. As a follow-up to this, we should also remove the
publish_filemethod in servicelayer.