Cyrillic in Libertinus Serif Bold Italic

[StefanPeev]

Cyrillic in Libertinus Serif Bold Italic

[StefanPeev]

I decided to share my Cyrillic proposal for Libertinus Serif Bold Italic. But what happened was not what I expected. Is it possible to ignore all commitments except Cyrillic in Libertinus Serif Bold Italic?

[khaledhosny]

I’m rebasing this on master, hold on for a moment.

[StefanPeev]

OK!

[khaledhosny]

I cleaned up and push to cyrillic branch in this repo (I couldn’t push to your fork). You can pull this branch and force push it to yours to update this pull request. Something like:

git checkout cyrillic
git fetch git@github.com:libertinus-fonts/libertinus.git cyrillic
git reset --hard FETCH_HEAD
git push -f

[StefanPeev]

After

git fetch git@github.com:libertinus-fonts/libertinus.git cyrillic

I receive

Fatal: Could note read from remote repository

[StefanPeev]

And also:

The authenticity of host 'github.com (192.30.253.113)' can't be established.

[khaledhosny]

Try git fetch https://github.com/libertinus-fonts/libertinus.git cyrillic instead.

[StefanPeev]

Now everything is OK. What is the next step?

[khaledhosny]

You should run make check locally and fix reported issues. There seem to be some glyphs with intersecting paths and this should be fixed (if this is left intentionally, then check Element → Glyph Info → Mark for unlink… so that we fix it at build time). Don’t also forget to run make normalize before committing.

[StefanPeev]

I wanted to submit only this file - LibertinusSerif-BoldItalic.sfd.
I'll make normalize to the file but how to PR only LibertinusSerif-BoldItalic.sfd?

[khaledhosny]

Normally, make normalize should not make changes to any other files than the one(s) you edited, if it does then something is broken (it may process on all the files the first time you run it, but will make no changes to unchanged files). Any way, you can always selectively commit the file you want and ignore the rest.

[StefanPeev]

I fail with make normalize command. Is anywhere step by step instructions?

[StefanPeev]

I executed this command only once and on UFO files...

[khaledhosny]

The steps are mentioned in the README https://github.com/libertinus-fonts/libertinus#contributing. Basically, you just edit the SFD file, run make normalize and then make check, if all is good commit the SFD file(s) you changed and the corresponding OTF file(s). The files you didn’t touch should remain unchanged, if not please elaborate more on what changes you are seeing.

[khaledhosny]

Please do not change the font encoding. The last commit should be reverted and open the font a fresh keeping the existing font encoding to avoid unnecessary file changes.

[khaledhosny]

Fixed and pushed manually, thanks.