[pull] master from kubernetes-sigs:master #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Currently, the controller will instantly shutdown and return when its context gets cancelled, leaving active reconciliations be. This change makes it wait for those before finishing shutdown.
* ✨ Deduplicate events before sending them into the workqueue.
This avoids race conditions where extra reconciles can happen rarely.
* ✨ Switch to map[string]struct{} to reduce memory usage slightly.
Also make sure that enqueue_mapped preserves order.
* 📝 Update function doc for getOwnerReconcileRequest.
* 🎨 Fix up duplication tests and ensure Update for _mapped dedups between both objects.
🐛 Controller: Wait for all reconciliations before shutting down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )