This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Implement service removal flag #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Mar 12, 2017
app.go
Outdated
| if rmService { | ||
| fmt.Println("Removing service...") | ||
| if err := c.ServiceRemove(context.Background(), id); err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
I guess this should be on stderr
alexellis
reviewed
Mar 12, 2017
app.go
Outdated
| @@ -46,6 +47,7 @@ func main() { | |||
| flag.StringVar(&network, "network", "", "Docker swarm network name") | |||
|
|
|||
| flag.BoolVar(&showlogs, "showlogs", true, "show logs from stdout") | |||
| flag.BoolVar(&rmService, "rm", false, "remove service after completion") | |||
There was a problem hiding this comment.
Could you call this variable removeService? The flag name is OK.
|
Thanks for the change @johnharris85 - just a couple of minor comments. Is this something you could use in your workflow btw? I've not got a PR template yet but could you say how you tested this - positive/negative case. |
|
Made those changes. Just heading out now but will try add a test case later. |
|
Great - thanks for updating. If you could rebase/squash your commits into one and fix the README conflict I'll merge. 👍 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of service removal flag for deleting the service after completion.
Motivation and Context
Allows users to automatically have the service removed after it finishes running.
How Has This Been Tested?
Tested with and without
-rmflag and experienced expected results. No negative test yet (in case the removal doesn't succeed for some reason).Types of changes
Checklist: