DXCDT-21: Global client data source

[willvedd]

Proposed Changes

Adding global client data source. Similarly to #511 , this PR heavily references @yinzara 's #363.

Still in draft as I better understand the use case and expected attributes; I've pointed out some inconsistencies below.

Acceptance Test Output

$ make testacc TESTS=TestAccXXX

=== RUN   TestAccDataGlobalClient
--- PASS: TestAccDataGlobalClient (3.95s)
PASS

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[willvedd]

@sergiughf At this point in time, I can't think a reasonable use case for exposing the client secret, but it's in line with the other client data source. What do you think about including?

[sergiught]

Considering we're using this as a data source to be ingested elsewhere I would tend to prefer removing it so we don't store it inside the state, just because it's a secret. If a valid use case for us having it there presents itself we could always re-add it. Would this work?

[yinzara]

Just thought I'd mention, I use my custom branch that has this data source to keep different tenants custom login pages synced. Specifically I have a master tenant that has my preferred custom login page and I use this data source to copy between tenants.

[willvedd]

@yinzara Really appreciate the input. After some investigation, that appears to be the primary use case for the global client DS. Am I correct in believing that you do not require the fetching of the client secret?

[willvedd]

@sergiughf With our decision to remove client_secret from the global client schema, it also makes sense to remove for all clients. I don't believe we've released that DS yet so this should be fine. Can always add in if someone has a compelling use case for it.