-
-
Notifications
You must be signed in to change notification settings - Fork 372
Fixes for various JSON/non-JSON content issues #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this just about the files endpoint or is there others that don't return JSON? |
@jprosevear Audio endpoints are another one |
My thought was to pass a named param to select the parsing option and default to json. Then change the default for files and audio to limit the breaking damage. Not sure if that's the right path though |
Yep, saw that in one of the PRs. I'd prefer just just always check if Strings can be JSON and always return raw if there are any errors - that way it should work for future endpoints, unforseen edge cases, etc. not sure of downsides to this approach |
Released in ruby-openai v8 |
[BREAKING CHANGE]
To Test
Update gemfile:
Run
bundle install
Related Issues (?)
#277
#314
#416
#421
#562
Related PRs (?)
#474
#504
#540
#544
All Submissions: