Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider proxy when caching a stream #109

Closed
cfal opened this issue Jul 4, 2020 · 2 comments · Fixed by #114
Closed

Consider proxy when caching a stream #109

cfal opened this issue Jul 4, 2020 · 2 comments · Fixed by #114

Comments

@cfal
Copy link
Contributor

cfal commented Jul 4, 2020

It looks like PoolKeys only consider host and port, which can lead to problems if a proxy is being used as a gateway to internal addresses - eg. proxy1 connects to 1.2.3.4 in a private network, proxy2 connects to 1.2.3.4 in another private network. Another (perhaps more limiting) option might be to make proxies agent-scoped, so that different connection pools are used.

@jsha
Copy link
Collaborator

jsha commented Jul 4, 2020

Good catch! I think it's reasonable to make proxy part of PoolKey. Scoping proxies to agents is appealing, but that would require an API break for something that's just as easily solved internally.

@algesten
Copy link
Owner

algesten commented Jul 5, 2020

Yeah I agree. We should put proxy into the pool key.

@jsha jsha closed this as completed in #114 Jul 8, 2020
jsha pushed a commit that referenced this issue Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants