Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cookie header RFC6265 compliant #130

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Make Cookie header RFC6265 compliant #130

merged 1 commit into from
Aug 7, 2020

Conversation

cazgp
Copy link
Contributor

@cazgp cazgp commented Aug 5, 2020

Fixes #129

cazgp
cazgp commented Aug 5, 2020
View reviewed changes
src/unit.rs Outdated Show resolved Hide resolved
jsha
jsha requested changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix! Would you be able to write a unittest for this?

src/unit.rs Outdated Show resolved Hide resolved
@cazgp
Copy link
Contributor Author

cazgp commented Aug 6, 2020

@jsha all done and two tests added!

jsha
jsha approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix! 🚀

@jsha jsha merged commit 22d815e into algesten:master Aug 7, 2020
@jsha jsha mentioned this pull request Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookie implementation uses one Header per Cookie instead of one Header for all Cookies
2 participants
@cazgp @jsha