Clear Content-Length header from redirected requests #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
Jun 18, 2021
|
Yep for sure let me give it a go
…On Fri, 18 Jun 2021 at 21:05, Jacob Hoffman-Andrews < ***@***.***> wrote:
Hi @guspower <https://github.com/guspower> ! I thought I'd save you some
time by forking your PR into #395
<#395>, and then I realize I can't
self-approve it. Want to merge in my c948d43
<c948d43>,
then I'll reapprove this and merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#394 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABSPBE2OZJBEUMXMIQR7CLTTORJ7ANCNFSM4652TWIQ>
.
|
|
I pushed the changes to satisfy the linter.
…On Fri, 18 Jun 2021, 21:12 Gus Power, ***@***.***> wrote:
Yep for sure let me give it a go
On Fri, 18 Jun 2021 at 21:05, Jacob Hoffman-Andrews <
***@***.***> wrote:
> Hi @guspower <https://github.com/guspower> ! I thought I'd save you some
> time by forking your PR into #395
> <#395>, and then I realize I can't
> self-approve it. Want to merge in my c948d43
> <c948d43>,
> then I'll reapprove this and merge?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#394 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABSPBE2OZJBEUMXMIQR7CLTTORJ7ANCNFSM4652TWIQ>
> .
>
|
jsha
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Content-Lengthheader from subsequent redirect requests if set. A test verifies the new behaviour.This issue causes
hyperto attempt to read a non-existent body from the redirect GET request, as seen when trying to usewiremock-rsto simulate redirect-on-post behaviour where the POST contains a payload. The issue has be replicated in an example project.