Add smoke test in examples. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This loads a list of top domain names (e.g. from https://tranco-list.eu/) and tries to fetch them all, in parallel. This can be used to exercise ureq and find panics.
lolgesten
approved these changes
Jun 23, 2020
examples/smoke-test/main.rs
Outdated
| let hostnames = bufreader | ||
| .lines() | ||
| .map(|line| Ok(line?.rsplit(",").next().unwrap().to_string())) | ||
| .collect::<io::Result<Vec<String>>>()?; |
There was a problem hiding this comment.
Here you don't need to collect, cause for var in iter { ... } works over iterator. But I guess you'd push the error handling into the for loop instead, so maybe it's cleaner this way.
examples/smoke-test/main.rs
Outdated
| type Bytes = Vec<u8>; | ||
| type Result<T> = result::Result<T, Oops>; | ||
|
|
||
| fn get(agent: &ureq::Agent, url: &String) -> Result<Bytes> { |
There was a problem hiding this comment.
For someone just scanning the code, Bytes often means this crate https://docs.rs/bytes/0.5.5/bytes/#bytes
Doesn't matter much though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loads a list of top domain names (e.g. from
https://tranco-list.eu/) and tries to fetch them all, in parallel. This
can be used to exercise ureq and find panics.