feat(rules): endpoint implementation #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing tests |
clement-leprovost
suggested changes
Jul 5, 2017
algoliasearch/index.py
Outdated
| before saving this batch? Default is False. | ||
| """ | ||
| params = {'forwardToReplicas': forward_to_replicas, 'clearExistingRules': clear_existing_rules} | ||
| return self._req(False, '/rules/batch', 'PUT', params, data) |
There was a problem hiding this comment.
The batch endpoint uses POST, not PUT.
algoliasearch/index.py
Outdated
| params =- {'forwardToReplicas': forward_to_replicas} | ||
| return self._req(False, '/rules/%s' % str(objectID), 'DELETE', params) | ||
|
|
||
| def clear_rule(self, forward_to_replicas=False): |
There was a problem hiding this comment.
I would prefer clear_rules (plural) rather than clear_rule (singular), as this endpoint clears all rules.
algoliasearch/index.py
Outdated
| params = {'forwardToReplicas': forward_to_replicas} | ||
| return self._req(False, '/rules/clear', 'POST', params) | ||
|
|
||
| def search_rules(self, query=None, anchoring=None, context=None, page=0, hitsPerPage=20): |
There was a problem hiding this comment.
It would be better not to hard-code the default values for page and hitsPerPage in the API client. If you omit these values, the API will use the default; so I had rather put None as default.
algoliasearch/index.py
Outdated
|
|
||
| def search_rules(self, query=None, anchoring=None, context=None, page=0, hitsPerPage=20): | ||
| """ | ||
| Search for a rule inside the index. |
There was a problem hiding this comment.
Search for rules, not just a single one. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.