feat: Add support for the /1/isalive endpoint
#277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint does an application-level ping. It is only useful for diagnosis purposes, or to pre-establish a connection before running actual operations.
1 similar comment
| Test if the server is alive. | ||
| This performs a simple application-level ping. If up and running, the server answers with a basic message. | ||
| """ | ||
| return self._req(True, '/1/isalive', 'GET') |
There was a problem hiding this comment.
The is_search parameter is not super explicit it switches between APPID-1.algolia.net and APPID-dsn.algolia.net. I think in that case we don't need it.
There was a problem hiding this comment.
Yes, I know, but I'd rather use it exactly for that reason:
- If we want to test that the cluster is up, better target the dynamic DNS anyway, it doesn't hurt.
- "Warming up" a connection is most likely to be useful for searches than for write operations.
@ercolanelli-leo Is that OK for you?
There was a problem hiding this comment.
Yes, you are right, I actually missed the part about warming up the connection in your PR description.
In that case it makes sense for me, and the tests pass, let's merge it!
shortcuts
pushed a commit
that referenced
this pull request
Nov 24, 2023
…on (#277) * chore(ci): fix mainGenerator in clients.configchore/main-generator.json * chore: update release issue description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint does an application-level ping. It is only useful for diagnosis purposes, or to pre-establish a connection before running actual operations.