Adds replace_all_rules and replace_all_synonyms #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
commented
Nov 14, 2018
nunomaduro
commented
Nov 19, 2018
julienbourdeau
changed the title
algoliasearch/index.py
Outdated
| @param synonyms the synonyms to upload as a list of python dictionary. | ||
| the dictionary must contain an objectID key. | ||
| """ | ||
| for synonym in synonyms: |
There was a problem hiding this comment.
Should we really add this verification in v1's 🤔
This makes replacesAllSynonyms and batchSynonyms behave differently.
There was a problem hiding this comment.
@julienbourdeau I believe new methods should follow the specs. The specs defines that synonyms must contain a valid ObjectID. I think it's fine.
| 'replaceExistingSynonyms': True | ||
| } | ||
|
|
||
| return self._req(False, '/synonyms/batch', 'POST', request_options, params, data=synonyms) |
There was a problem hiding this comment.
Did you not use batch_synonyms on purpose because of the requestOptions?
There was a problem hiding this comment.
@julienbourdeau Because all the extra works of setting the params of the batch_synonyms. Is just more simple call one line.
nunomaduro
force-pushed
the
feat/adds-replace-rules-and-replace-synonims
branch
from
81d04e0 to
4d471da
Compare
shortcuts
pushed a commit
that referenced
this pull request
Nov 24, 2023
* chore(ci): use different branch to test release * chore: process release on main_test branch * chore: revert release.config.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Adds methods
replace_all_rulesandreplace_all_synonims.