Skip to content

Add support of HTTP_PROXY environment variable #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add support of HTTP_PROXY environment variable #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5445e2
Add HTTP_PROXY env
vinc Mar 14, 2018
3e354cc
Add HTTP_PROXY to README
vinc Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ index.set_settings searchableAttributes: %w(
)
```

**Note:** If you are behind a proxy, set `HTTP_PROXY` environment variable.

## Search

You can now search for contacts using `firstname`, `lastname`, `company`, etc. (even with typos):
Expand Down
2 changes: 1 addition & 1 deletion lib/algolia/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def delete(uri, type = :write, request_options = {})
def thread_local_hosts(read)
thread_hosts_key = read ? "algolia_search_hosts_#{application_id}" : "algolia_hosts_#{application_id}"
Thread.current[thread_hosts_key] ||= (read ? search_hosts : hosts).each_with_index.map do |host, i|
client = HTTPClient.new
client = HTTPClient.new(ENV["HTTP_PROXY"])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed because the httpclient library already read this variables:

Any chance you could tell us what happens in this load_environment method in your case @vinc ? Maybe you have a REQUEST_METHOD variable forcing the code to look for cgi_http_proxy ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed yesterday our fork seemed to fix the issue we had on our production server, but we switched back to the original gem after reading your comment and everything is still working.

Therefor the issue we were having seems to have been totally unrelated!

So we can close this PR, and I apologize for your time spent on this :3

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem @vinc thanks for contributing!

client.ssl_config.ssl_version = @ssl_version if @ssl && @ssl_version
client.transparent_gzip_decompression = @gzip
client.ssl_config.add_trust_ca File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'resources', 'ca-bundle.crt'))
Expand Down