Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

Quotes are double escaped #734

Closed
rayrutjes opened this issue Mar 13, 2018 · 3 comments
Closed

Quotes are double escaped #734

rayrutjes opened this issue Mar 13, 2018 · 3 comments
Labels
bug

Comments

@rayrutjes
Copy link
Member

It seems like quotes get double escaped in the following scenario:

  • submit a search input with a query containing '
  • resulting page displays the query with escaped value instead of the quote
    image
@rayrutjes rayrutjes added the bug label Mar 13, 2018
@rayrutjes
Copy link
Member Author

I've been unable to re-produce this.
It seems unrelated to this plugin.

@rayrutjes rayrutjes reopened this May 14, 2018
rayrutjes added a commit that referenced this issue May 14, 2018
@rayrutjes
fix: do not escape query passed to frontend
e8ff424 
The query retrieved in the URL is potentially used as input value.
Escaping the HTML is not expected here as it makes the value unusable for that purpose.
In other places where used, the query is already escaped.

Closes: #734
@rayrutjes rayrutjes mentioned this issue May 14, 2018
Merged
@rayrutjes rayrutjes reopened this May 22, 2018
@rayrutjes
Copy link
Member Author

This issue still isn't solved as quotes still are prefixed with backslashes: gone\'s \"

@Mamaduka
Copy link
Contributor

I think wp_unslash() might be the right function for "escaping" in this case.

rayrutjes added a commit that referenced this issue May 22, 2018
@rayrutjes
fix: remove backslashes from quotes coming from URL params
4e5e109 
Closes: #734, #751
@rayrutjes rayrutjes mentioned this issue May 22, 2018
Merged
rayrutjes added a commit that referenced this issue May 22, 2018
@rayrutjes
fix: remove backslashes from quotes coming from URL params
65f8235 
Closes: #734, #751
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mamaduka @rayrutjes