fix(js): add version to user agent #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
requested review from
a team and
damcou
and removed request for
a team
bodinsamuel
reviewed
Jan 25, 2022
There was a problem hiding this comment.
NB: we want to avoid breaking changes with UA
cf https://github.com/algolia/algoliasearch-client-javascript/blob/97ebde60bf2220ef4d81c569c853196a3b06f723/packages/algoliasearch/src/__tests__/default.test.ts
bodinsamuel
approved these changes
Jan 26, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
* fix: add version to user agent * fix: user agent format
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-278
Changes included: