Skip to content

chore(ci): validate pull-request title #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2022
Merged

chore(ci): validate pull-request title #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2c9083f
chore(ci): validate pr title
eunjae-lee Feb 11, 2022
33f696d
chore: remove semantic pull request config
eunjae-lee Feb 11, 2022
7b4e09e
chore: fix name of workflow
eunjae-lee Feb 11, 2022
75f14c0
chore: clean up workflow
eunjae-lee Feb 11, 2022
d4afd07
chore: move title checking to check.yml
eunjae-lee Feb 11, 2022
767bf72
Revert "chore: move title checking to check.yml"
eunjae-lee Feb 11, 2022
6d56591
chore: remove unnecessary setup
eunjae-lee Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/semantic.yml
View file
Open in desktop

This file was deleted.

19 changes: 19 additions & 0 deletions .github/workflows/pr-title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Validate pull-request title

on:
pull_request:
types: [opened, edited, synchronize]

jobs:
setup:
runs-on: ubuntu-20.04
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Pull Request title rules
uses: deepakputhraya/action-pr-title@v1.0.2
with:
regex: '^(?:(feat)|(fix)|(docs)|(style)|(refactor)|(perf)|(test)|(build)|(ci)|(chore)|(revert))\((?:(javascript)|(php)|(java)|(cts)|(spec)|(script)|(ci))\): .+'
Comment on lines +18 to +19
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added ci as a scope. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next improvement could be to find the languages with a small bash script but it's fine for now