Skip to content

fix(script): use process.cwd() instead of __dirname #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2022
Merged

fix(script): use process.cwd() instead of __dirname #142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
288d07a
fix(scripts): use process.cwd() instead of __dirname
eunjae-lee Feb 17, 2022
73a6360
chore: add comment
eunjae-lee Feb 18, 2022
3e63c9e
chore: throw error when file not found
eunjae-lee Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions scripts/pre-gen/setHostsOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ type AdditionalProperties = Partial<{
}>;

async function setHostsOptions(): Promise<void> {
const openapitoolsPath = path.join(__dirname, '../../openapitools.json');
const openapitoolsPath = path.join(process.cwd(), '../openapitools.json');
if (!(await stat(openapitoolsPath))) {
throw new Error(
`File not found ${openapitoolsPath}.\nMake sure your run scripts from the root directory using yarn workspace.`
);
}
const openapitools = JSON.parse(await readFile(openapitoolsPath, 'utf-8'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the same check as L48, with a similar mention to make sure to use workspaces to run the script


const [language, client] = process.argv.slice(2);
Expand All @@ -43,10 +48,12 @@ async function setHostsOptions(): Promise<void> {
throw new Error(`Generator not found: ${generator}`);
}

const specPath = path.join(__dirname, `../../specs/bundled/${client}.yml`);
const specPath = path.join(process.cwd(), `../specs/bundled/${client}.yml`);

if (!(await stat(specPath))) {
throw new Error(`File not found ${specPath}`);
throw new Error(
`File not found ${specPath}.\nMake sure your run scripts from the root directory using yarn workspace.`
);
}

try {
Expand Down