fix: remove credentials from stacktrace #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
force-pushed
the
fix/credentials
branch
from
444cd8d to
03246e0
Compare
DevinCodes
previously approved these changes
Nov 29, 2021
| * the end user to debug / store stack frames even | ||
| * when a retry error does not happen. | ||
| */ | ||
| console.log('Retryable failure', stackFrameWithoutCredentials(stackFrame)); |
There was a problem hiding this comment.
For now this is probably fine, but we might want to extract this into a Logger class that the user can swap for something custom (e.g. writing to a file or server instead of to the console).
There was a problem hiding this comment.
Good idea, I created a ticket
shortcuts
previously approved these changes
Nov 29, 2021
Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove credentials from stackTrace and print stackFrame when a retry happen.
There is no true logger for now so it's just
console.log