Skip to content

fix(script): build javascript-algoliasearch after other clients #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 3, 2022
Merged

fix(script): build javascript-algoliasearch after other clients #223

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7936bd8
fix(script): build `javascript-algoliasearch` after other clients
shortcuts Mar 2, 2022
f64878f
Merge branch 'main' into fix/build-script-algoliasearch
shortcuts Mar 2, 2022
ae4c090
Merge branch 'main' into fix/build-script-algoliasearch
shortcuts Mar 3, 2022
d7d0a6e
Merge branch 'main' into fix/build-script-algoliasearch
shortcuts Mar 3, 2022
12fd0e8
Merge branch 'main' into fix/build-script-algoliasearch
shortcuts Mar 3, 2022
229cd11
apply changes from suggestion
shortcuts Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions scripts/buildClients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,20 @@ async function buildAllClients(
}

export async function buildClients(
generators: Generator[],
allGenerators: Generator[],
verbose: boolean
): Promise<void> {
const langs = [...new Set(generators.map((gen) => gen.language))];
const langs = [...new Set(allGenerators.map((gen) => gen.language))];

// We exclude `javascript-algoliasearch` from the build batch because it
// is made of built generated clients and can cause race issue when executed
// together.
const jsAlgoliasearch = allGenerators.find(
(gen) => gen.key === 'javascript-algoliasearch'
);
const generators = allGenerators.filter(
(gen) => gen.key !== 'javascript-algoliasearch'
);

await Promise.all([
Promise.all(
Expand All @@ -103,4 +113,8 @@ export async function buildClients(
.map((lang) => buildAllClients(lang, verbose))
),
]);

if (jsAlgoliasearch) {
await buildPerClient(jsAlgoliasearch, verbose);
}
}