Skip to content

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Mar 17, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Follow up of #264

There was multiple issues in this PR:

  • Updating the dependencies on a version bump does not apply the changes on the yarn.lock
  • Negative scope of the dist folder did not worked, I've went with a verbose solution
  • As algoliasearch depends on other client, I've put the step after the generated client bulds

Why

The bump of generated client shouldn't happen out of the release process, but will still happen when we bump a utils package. This PR ensures that it can be done via the CI without touching the yarn.lock etc.

🧪 Test

CI :D

@netlify
Copy link

netlify bot commented Mar 17, 2022

✔️ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 7503b99

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6234a1d7b2c3150008ea1948

@shortcuts
Copy link
Member Author

shortcuts commented Mar 17, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@shortcuts shortcuts force-pushed the chore/ci-algoliasearch-race branch 5 times, most recently from ff9bae7 to aec1e76 Compare March 18, 2022 14:33
@shortcuts shortcuts force-pushed the chore/ci-algoliasearch-race branch from aec1e76 to 7503b99 Compare March 18, 2022 15:14
@shortcuts shortcuts self-assigned this Mar 18, 2022
@shortcuts shortcuts requested review from a team, eunjae-lee and damcou and removed request for a team March 18, 2022 15:35
@shortcuts shortcuts marked this pull request as ready for review March 18, 2022 15:35
@shortcuts shortcuts merged commit 9e24500 into chore/release-js-update Mar 21, 2022
@shortcuts shortcuts deleted the chore/ci-algoliasearch-race branch March 21, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant