Skip to content

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Mar 17, 2022

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@millotp millotp self-assigned this Mar 17, 2022
@netlify
Copy link

netlify bot commented Mar 17, 2022

Deploy Preview for api-clients-automation failed.

Name Link
🔨 Latest commit ec06736
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/624c2d98f1dbf10008db8d57

@millotp millotp changed the title feat: ignore clients on local but not on CI feat(ci): ignore clients on local but not on CI Mar 18, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea/initiative but I think it's a bit too early.

As we've seen with submodules, we've removed clients too fast and I would like to have all of the release process PR merged/tested before doing it again

@millotp millotp force-pushed the feat/ignore-clients branch 2 times, most recently from a6b3789 to 05cbd52 Compare April 5, 2022 09:51
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 5, 2022

🔨 The codegen job will run at the end of the CI.

Make sure your last commit does not contains generated code, it will be automatically pushed by our CI.

@shortcuts
Copy link
Member

Could you try to empty cache when the branch is up to date? I'd like to make sure everything runs from scratch

@millotp
Copy link
Collaborator Author

millotp commented Apr 5, 2022

It's not working and it won't work because of the workspaces, I have to fix that first

@shortcuts
Copy link
Member

It's not working and it won't work because of the workspaces, I have to fix that first

Ok that's what I was wondering

@millotp millotp force-pushed the feat/ignore-clients branch from 05cbd52 to ec06736 Compare April 5, 2022 11:52
@millotp millotp marked this pull request as draft April 5, 2022 11:57
@millotp millotp closed this Apr 8, 2022
@millotp millotp deleted the feat/ignore-clients branch April 28, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants