feat(php): Generate remaining PHP clients with PHP docs APIC-327 #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
This seems to be the content for 3 PRs, could you create stacked ones pls? |
|
Massive PR ! You don't need to commit what's generated, I think it will simplify the PR a lot |
shortcuts
reviewed
Apr 4, 2022
|
#313 introduces a cache key change in the |
…/algolia/api-clients-automation into feat/APIC-355/php-models-returns
shortcuts
reviewed
Apr 4, 2022
|
Once #332 is merged, your PR will be fixed, waiting for it to start reviewing the generated code 👓 |
…/algolia/api-clients-automation into feat/APIC-355/php-models-returns # Conflicts: # .github/.cache_version # templates/php/api.mustache
…/algolia/api-clients-automation into feat/APIC-355/php-models-returns
shortcuts
reviewed
Apr 8, 2022
shortcuts
reviewed
Apr 8, 2022
|
From my php noob eyes it does look good, I'd like a review from a connoisseur though |
Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
shortcuts
reviewed
Apr 8, 2022
millotp
reviewed
Apr 8, 2022
This was referenced Apr 11, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-327
Changes included:
🧪 Test