Skip to content

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Follow up still, sorry for all the fixes.

  • Run JavaScript algoliasearch job before the codegen, so we can push changes in release
  • Run codegen setup step after restoring artifacts, so we are sure yarn.lock is up to date
  • Cancel Netlify run on PR release

🧪 Test

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 724667a
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/628e387bcbd3250008c8f7bd

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 25, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts force-pushed the fix/release-scripts branch from f85543e to c05b0a4 Compare May 25, 2022 13:35
@shortcuts shortcuts self-assigned this May 25, 2022
@shortcuts shortcuts requested review from millotp and eunjae-lee May 25, 2022 13:37
@@ -0,0 +1,7 @@
# This $BRANCH variable comes from the Netlify env
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the bash script :( did not found a way to match both things

@shortcuts shortcuts force-pushed the fix/release-scripts branch from 4fea212 to 724667a Compare May 25, 2022 14:08
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants