Skip to content

feat(js-client): remove use of Enum, allow typings in CTS #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 6, 2022
Merged

feat(js-client): remove use of Enum, allow typings in CTS #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7b7d59
feat(js-client): remove use of `Enum`, allow typings in CTS
shortcuts Jan 5, 2022
88e78b8
Merge branch 'main' into feat/APIC-245/js-no-enum
shortcuts Jan 5, 2022
a3ff7f9
Merge branch 'main' into feat/APIC-245/js-no-enum
shortcuts Jan 5, 2022
7e50493
Merge branch 'main' into feat/APIC-245/js-no-enum
shortcuts Jan 6, 2022
3660f5b
merge main, regenerate insights client
shortcuts Jan 6, 2022
caa7dba
merge main, fix generateCTS
shortcuts Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions ...ts/algoliasearch-client-java-2/algoliasearch-core/com/algolia/model/BaseSearchParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
/** BaseSearchParams */
public class BaseSearchParams {

@SerializedName("query")
private String query = "";

@SerializedName("similarQuery")
private String similarQuery = "";

Expand Down Expand Up @@ -108,25 +105,6 @@ public class BaseSearchParams {
@SerializedName("enableReRanking")
private Boolean enableReRanking = true;

public BaseSearchParams query(String query) {
this.query = query;
return this;
}

/**
* The text to search in the index.
*
* @return query
*/
@javax.annotation.Nonnull
public String getQuery() {
return query;
}

public void setQuery(String query) {
this.query = query;
}

public BaseSearchParams similarQuery(String similarQuery) {
this.similarQuery = similarQuery;
return this;
Expand Down Expand Up @@ -836,7 +814,6 @@ public boolean equals(Object o) {
}
BaseSearchParams baseSearchParams = (BaseSearchParams) o;
return (
Objects.equals(this.query, baseSearchParams.query) &&
Objects.equals(this.similarQuery, baseSearchParams.similarQuery) &&
Objects.equals(this.filters, baseSearchParams.filters) &&
Objects.equals(this.facetFilters, baseSearchParams.facetFilters) &&
Expand Down Expand Up @@ -905,7 +882,6 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
return Objects.hash(
query,
similarQuery,
filters,
facetFilters,
Expand Down Expand Up @@ -945,7 +921,6 @@ public int hashCode() {
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("class BaseSearchParams {\n");
sb.append(" query: ").append(toIndentedString(query)).append("\n");
sb
.append(" similarQuery: ")
.append(toIndentedString(similarQuery))
Expand Down
8 changes: 4 additions & 4 deletions clients/algoliasearch-client-java-2/algoliasearch-core/com/algolia/model/Consequence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
public class Consequence {

@SerializedName("params")
private Params params;
private ConsequenceParams params;

@SerializedName("promote")
private List<Promote> promote = null;
Expand All @@ -25,7 +25,7 @@ public class Consequence {
@SerializedName("userData")
private Map<String, Object> userData = null;

public Consequence params(Params params) {
public Consequence params(ConsequenceParams params) {
this.params = params;
return this;
}
Expand All @@ -36,11 +36,11 @@ public Consequence params(Params params) {
* @return params
*/
@javax.annotation.Nullable
public Params getParams() {
public ConsequenceParams getParams() {
return params;
}

public void setParams(Params params) {
public void setParams(ConsequenceParams params) {
this.params = params;
}

Expand Down
Loading