chore(hook): simplify pre-commit hook #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
force-pushed
the
chore/simplify-hook
branch
from
c7fe19d to
5f56782
Compare
millotp
force-pushed
the
chore/simplify-hook
branch
from
5f56782 to
078ea29
Compare
shortcuts
approved these changes
Jun 8, 2022
| module.exports = { | ||
| patterns: [ | ||
| // Ignore the roots and go down the tree by negating hand written files | ||
| 'specs/bundled/*.yml', |
There was a problem hiding this comment.
Let's closely look at the next PRs pushed code so we can make sure we did not broke anything here
| @@ -1,24 +1,63 @@ | |||
| /* eslint-disable @typescript-eslint/no-var-requires */ | |||
There was a problem hiding this comment.
It seems good for now! We can add more tests later :D
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
I wanted to add a mix of
positive,negative,positiveglob to the file to unstage, but it was not possible because we splitpositiveandnegativeglob before matching.Micromatch is already able to handle a list of pattern, we don't need extra logic, I didn't saw any edge cases while testing.
Changes included:
🧪 Test
Try to add files to stage and unstage and run the command
node scripts/ci/husky/pre-commit.js