chore: fix version bump for Java #655
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| ...version, | ||
| releaseType: 'patch', | ||
| ...(commitTypes.has('fix') ? undefined : { skipRelease: true }), | ||
| next: getNextVersion(currentVersion, 'patch'), |
There was a problem hiding this comment.
why do we include next here, while we can compute it anywhere based on currentVersion and releaseType?
There was a problem hiding this comment.
Oops sorry I had auto merge on.
It was previously computed at the changelog creation level, I've put it a level above as this is where the releaseType is computed. Do you think there's a better place for it?
There was a problem hiding this comment.
A bit of history FYI, I avoided to add next version there especially because JS actually have independent versions.
There was a problem hiding this comment.
I've made sure here it still follows the same logic: #656
4 participants
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
The next Java version seems incorrectly bumped in #653, this PR adds a small edge case to bump the version normally but keep the
-SNAPSHOT.🧪 Test
CI :D