Skip to content

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-524

Changes included:

This PR fixes the regex match in our renovate config, which allows us to bump package.mustache files and the openapitools.json config in our weekly PRs.

I've also removed algoliasearch from the ignored list, as it's not a generated package.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team June 9, 2022 13:27
@shortcuts shortcuts self-assigned this Jun 9, 2022
@shortcuts shortcuts requested review from damcou and eunjae-lee and removed request for a team June 9, 2022 13:27
@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit bad9c71
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62a1f54a596156000848c6d2

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 9, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insane level of automation !

"description": "Update openapitools-cli version in the config file",
"fileMatch": [
"config/openapitools.json"
"openapitools.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it finds the folder config by itself ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly! Any files matching the fileMatch pattern will be selected

"package.mustache"
],
"matchStrings": [
"\\s\"@types/node\": \"(?<currentValue>.*?)\",\\s"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to select everything under dependencies with regex ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to at first, but did not found a way as depNameTemplate does not accept an array

@shortcuts shortcuts merged commit 1821509 into main Jun 9, 2022
@shortcuts shortcuts deleted the chore/renovate-bump-mustache-files branch June 9, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants