Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol to not generate a valid JSX string #134

Closed
armandabric opened this issue Aug 4, 2017 · 0 comments
Closed

Symbol to not generate a valid JSX string #134

armandabric opened this issue Aug 4, 2017 · 0 comments
Labels

Comments

@armandabric
Copy link
Collaborator

armandabric commented Aug 4, 2017

const mySymbol = Symbol('foo');

console.log(reactElementToJsxString(<Button type={mySymbol} />));

It will output:

<Button type={Symbol(foo)} />

A valid JSX output could be:

<Button type={Symbol('foo')} />

See:

@armandabric armandabric added the bug label Aug 4, 2017
armandabric added a commit to armandabric/react-element-to-jsx-string that referenced this issue Oct 8, 2017
Closes algolia#134

BREAKING CHANGE: Symbol description are now correctly quoted. This change the output if you use Symbol in your code
armandabric added a commit that referenced this issue Oct 8, 2017
Closes #134

BREAKING CHANGE: Symbol description are now correctly quoted. This change the output if you use Symbol in your code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant