Skip to content

Commit f923e52

Browse files
author
Eunjae Lee
authored
fix: fix --no-browse option (#195)
1 parent 06c6977 commit f923e52

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

packages/shipjs/src/flow/prepare.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ async function prepare({
2525
firstRelease = false,
2626
releaseCount,
2727
dryRun = false,
28+
noBrowse = false,
2829
}) {
2930
if (help) {
3031
printHelp();
@@ -61,6 +62,7 @@ async function prepare({
6162
stagingBranch,
6263
currentVersion,
6364
nextVersion,
65+
noBrowse,
6466
config,
6567
dir,
6668
dryRun,

packages/shipjs/src/step/prepare/createPullRequest.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export default ({
88
stagingBranch,
99
currentVersion,
1010
nextVersion,
11+
noBrowse,
1112
config,
1213
dir,
1314
dryRun,
@@ -60,7 +61,7 @@ export default ({
6061
const createPullRequestCommand = [
6162
'hub pull-request',
6263
`--base ${destinationBranch}`,
63-
'--browse',
64+
noBrowse ? undefined : '--browse',
6465
'--push',
6566
pullRequestReviewer ? `--reviewer ${pullRequestReviewer}` : undefined,
6667
`--file ${filePath}`,

0 commit comments

Comments
 (0)