-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/147 allow updating mimetype datastorage to solve some file type determination case #148
Feature/147 allow updating mimetype datastorage to solve some file type determination case #148
Conversation
…ure/147__allow_updating_mimetype_datastorage_to_solve_some_file_type_determination_case
a1b3059
to
65b1cdc
Compare
I'm not sure we can easily touch mimetype detection without first resolving #113 #114 #115 #116 #117 and #118 serie, as modifying mimetype detection will probably modify precedence of builders, and modifying precedence of builder will reveal one or many of the mentionned issues. Also while you're touching mimetype datastorage, why not jumping directly to store |
@JulienPalard you're remark is interesting. Our strategy is the following one:
What do you think? Would you be interested in meeting in order to discuss about this large refactoring with @inkhey @buxx and me? The goal of this refactor is to convert preview-generator into a professionnal polished module (your work on preview-generator is clearly going into this direction; we also have core features refactoring required in order to achieve this goal) |
7964128
to
d14fe18
Compare
…ture/147__allow_updating_mimetype_datastorage_to_solve_some_file_type_determination_case
Ok for me. |
…ture/147__allow_updating_mimetype_datastorage_to_solve_some_file_type_determination_case
related to #147.
This add the feature and add a better support for raw file determination.