Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/147 allow updating mimetype datastorage to solve some file type determination case #148

Conversation

inkhey
Copy link
Contributor

@inkhey inkhey commented Nov 14, 2019

related to #147.
This add the feature and add a better support for raw file determination.

@inkhey inkhey force-pushed the feature/147__allow_updating_mimetype_datastorage_to_solve_some_file_type_determination_case branch from a1b3059 to 65b1cdc Compare November 14, 2019 14:02
This was referenced Nov 14, 2019
@JulienPalard
Copy link
Contributor

I'm not sure we can easily touch mimetype detection without first resolving #113 #114 #115 #116 #117 and #118 serie, as modifying mimetype detection will probably modify precedence of builders, and modifying precedence of builder will reveal one or many of the mentionned issues.

Also while you're touching mimetype datastorage, why not jumping directly to store (source_type, destination_type) instead of just source_type? It would help in selecting the right builder for the task, and in the future alowing to convert from A to C thrue B in case two distinct builders registered (A, B) and (B, C).

@lebouquetin
Copy link
Member

@JulienPalard you're remark is interesting. Our strategy is the following one:

  • fix the mimetypes for RAW images like @inkhey started to work on. then release a last version of preview-generator without (important) breaking changes
  • start a large refactor including the storage like (source_type, destination_type) in order to deliver a preview-generator 1.x branch of development.

What do you think? Would you be interested in meeting in order to discuss about this large refactoring with @inkhey  @buxx and me?

The goal of this refactor is to convert preview-generator into a professionnal polished module (your work on preview-generator is clearly going into this direction; we also have core features refactoring required in order to achieve this goal)

@inkhey inkhey force-pushed the feature/147__allow_updating_mimetype_datastorage_to_solve_some_file_type_determination_case branch from 7964128 to d14fe18 Compare November 19, 2019 13:35
@buxx
Copy link
Contributor

buxx commented Nov 21, 2019

Ok for me.

@inkhey inkhey merged commit 93366e2 into develop Nov 21, 2019
@inkhey inkhey deleted the feature/147__allow_updating_mimetype_datastorage_to_solve_some_file_type_determination_case branch November 21, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants