api: Regenerate client interfaces for timestamp, ready, and simulate endpoints #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
commented
Apr 20, 2023
algochoi
commented
Apr 21, 2023
algochoi
commented
Apr 25, 2023
.test-env
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Configs for testing repo download: | |||
| SDK_TESTING_URL="https://github.com/algorand/algorand-sdk-testing" | |||
| SDK_TESTING_BRANCH="master" | |||
| SDK_TESTING_BRANCH="path-unit-tests" | |||
There was a problem hiding this comment.
todo: revert back to master
algochoi
changed the title
winder
reviewed
Apr 26, 2023
Comment on lines
59
to
61
| s.Step(`^we make a SetSyncRound call against round (\d+)$`, weMakeASetSyncRoundCallAgainstRound) | ||
| s.Step(`^we make a GetSyncRound call$`, weMakeAGetSyncRoundCall) | ||
| s.Step(`^we make a UnsetSyncRound call$`, weMakeAUnsetSyncRoundCall) |
There was a problem hiding this comment.
There they are. Should be able to add in unit.sync.
|
Did the simulate endpoint fail to generate? |
winder
reviewed
Apr 26, 2023
winder
changed the title
algochoi
changed the title
ahangsu
approved these changes
Apr 28, 2023
winder
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly uses the generator to generate the timestamp offset, ready, and simulate endpoints.
Also implements tests for the timestamp and ready endpoint.