Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algocfg(profile): Add file name to config file conflict message. #5262

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Apr 6, 2023

Summary

Add additional information when prompting to overwrite a config.json file. This should help in the event that algocfg profile set conduit -d "" falls back to the ALGORAND_DATA environment variable. This case is probably not very common for a normal installation, but could occur with testing scripts where a parameterized data directory is not properly set.

Test Plan

Manual testing.

@winder winder self-assigned this Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #5262 (446a196) into master (f4f5ec6) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5262      +/-   ##
==========================================
+ Coverage   53.78%   53.80%   +0.02%     
==========================================
  Files         450      450              
  Lines       56201    56201              
==========================================
+ Hits        30226    30241      +15     
+ Misses      23626    23615      -11     
+ Partials     2349     2345       -4     
Impacted Files Coverage Δ
cmd/algocfg/profileCommand.go 7.54% <0.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review April 6, 2023 15:22
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants