Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: increase heading levels, thus only one h1 is used #5291

Merged
merged 1 commit into from Apr 21, 2023
Merged

docs: increase heading levels, thus only one h1 is used #5291

merged 1 commit into from Apr 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2023

(1st part of invalidly closed #5280)

trivial

jannotti
jannotti approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the world-wide shortage of h1s, and the supply-chain issues that are likely to keep h1 levels at an all-time low, this seems like an important change to cut our overall h1 budget.

algorandskiy
algorandskiy previously requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not have value. The CommonMark Spec does not call # thing a title.

@ghost ghost changed the title increase heading levels, thus only one h1 is used docs: increase heading levels, thus only one h1 is used Apr 19, 2023
@ghost ghost requested a review from algorandskiy April 19, 2023 01:08
bbroder-algo
bbroder-algo approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better

@bbroder-algo bbroder-algo merged commit a79532b into algorand:master Apr 21, 2023
This was referenced May 9, 2023
Closed
Closed
Closed
@Algo-devops-service Algo-devops-service mentioned this pull request May 22, 2023
Merged
This was referenced May 24, 2023
Merged
Merged
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 12, 2023
Merged
@onetechnical onetechnical mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorandskiy algorandskiy Awaiting requested review from algorandskiy

Assignees
No one assigned
Labels
Enhancement external contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jannotti @algorandskiy @bbroder-algo