AVM: No low resources #5328
Merged
AVM: No low resources #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v9 changes several "resource accessing" opcodes to no longer accept "foreign array slots" as arguments - the resource id (for apps or assets) or the address (when accessing accounts) must be given. In the case of asset ids, this change could slip past contract authors pretty easily unless the opcode names are changed. So this PR changes opcode names. To use v9, authors will need to make explicit changes to their contracts. Resource access changes are the only thing in v9. So authors may feel free to delay this change. The complete list of changes, bucketed by the resource type being touched. App app_params_get app_get app_global_get_ex global_state_get_ex Account & App app_opted_in opted_in app_local_get_ex local_state_get_ex Asset asset_params_get asset_get Account & Asset asset_holding_get holding_get Account balance _deprecated_ min_balance _deprecated_ app_local_get local_state_get app_local_put local_state_put app_local_del local_state_del acct_params_get acct_get None, but for consistency app_global_get global_state_get app_global_put global_state_put app_global_del global_state_del
While doing so, ban AVM access to resources < 256, to keep rules for some opcodes simpler.
jannotti
force-pushed
the
no-low-resources
branch
from
4cc9f27
to
3b3e873
Compare
jannotti
force-pushed
the
no-low-resources
branch
2 times, most recently
from
4c01e9c
to
e8e7daf
Compare
jannotti
force-pushed
the
no-low-resources
branch
from
e8e7daf
to
8cb152f
Compare
ahangsu
reviewed
Apr 24, 2023
ahangsu
reviewed
Apr 24, 2023
ahangsu
reviewed
Apr 25, 2023
ahangsu
reviewed
Apr 25, 2023
ahangsu
reviewed
Apr 25, 2023
jasonpaulos
reviewed
May 1, 2023
ahangsu
reviewed
May 1, 2023
jasonpaulos
previously approved these changes
May 1, 2023
ahangsu
reviewed
May 2, 2023
ahangsu
reviewed
May 3, 2023
ahangsu
previously approved these changes
May 4, 2023
bbroder-algo
previously approved these changes
May 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #5328 +/- ##
==========================================
+ Coverage 55.28% 55.30% +0.01%
==========================================
Files 454 454
Lines 63713 63748 +35
==========================================
+ Hits 35225 35257 +32
+ Misses 26096 26086 -10
- Partials 2392 2405 +13
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonpaulos
approved these changes
May 5, 2023
ahangsu
approved these changes
May 5, 2023
bbroder-algo
approved these changes
May 5, 2023
This was referenced May 6, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New approach that allows resource opcodes to maintain compatibility in v9, which allows group resource sharing. Obsoletes a prior approach that deprecated a slew of opcodes and made new ones that could not access by static array slot.