DevOps: fix codecov uploading #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5345 +/- ##
==========================================
+ Coverage 53.78% 55.00% +1.22%
==========================================
Files 450 450
Lines 56201 62881 +6680
==========================================
+ Hits 30226 34588 +4362
- Misses 23626 25906 +2280
- Partials 2349 2387 +38
... and 439 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
force-pushed
the
codecov-debugging
branch
from
611bd21
to
cec73e6
Compare
algobarb
previously approved these changes
May 3, 2023
Yep. In fact, I accidentally didn't even use the variable in that version. Updated. |
excalq
approved these changes
May 3, 2023
algobarb
approved these changes
May 3, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While open source repositories should be able to upload without a token, Codecov support will often break with Github's API access. The recommended solution to this is to implement a codecov repository token in the implementation, even if open source.
This PR updates the bash uploader to latest as well as makes this change. The bash script is actually deprecated, but CircleCI orb usage cannot be implemented until codecov offers multi-platform support (arm64, darwin). Additionally, dropping in the new uploader would add about 100 MB of binary to the repository, so was not desired.
Since the update check was removed, we could make this a breaking change for CI - right now, if there are errors executing this, then it's ignored, which means that we do not block PRs for failing code coverage execution.
Test Plan
Verify that codecov results are uploaded.