consensus: Introduce versions v37 and v38 #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5397 +/- ##
==========================================
+ Coverage 55.39% 55.41% +0.01%
==========================================
Files 452 452
Lines 63812 63822 +10
==========================================
+ Hits 35351 35365 +14
- Misses 26031 26034 +3
+ Partials 2430 2423 -7
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
reviewed
May 19, 2023
cce
reviewed
May 19, 2023
cce
reviewed
May 19, 2023
jannotti
reviewed
May 19, 2023
bbroder-algo
previously approved these changes
May 19, 2023
algorandskiy
commented
May 19, 2023
bbroder-algo
approved these changes
May 22, 2023
jannotti
approved these changes
May 22, 2023
| 7: "07" + v7Compiled, | ||
| 8: "08" + v8Compiled, | ||
| 9: "09" + v9Compiled, | ||
| 10: "0a" + v10Compiled, |
There was a problem hiding this comment.
I don't feel strongly about this, but maybe we should insert a blank line above 10: ... so that go fmt won't re-indent all the above lines.
gmalouf
approved these changes
May 22, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New consensus versions v37 and v38 and appropriate fixes.
Test Plan
Existing tests. There are bunch of app test fixes because of
AppForbidLowResourcesand online accts tests b/c of circulation rules change.