Converting GT/LT uint struct fields to uint pointers #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to pass check that it is set
|
Thanks, looks good! I will let @winder also take a look. |
winder
reviewed
May 4, 2021
There was a problem hiding this comment.
Awesome, thanks! I was hoping you would update the other parameters while you were at it.
One tip that you might not know, it's really easy to take your branch for a test drive with sandbox. Create a config like the following:
$ cat config.barnjamin
export ALGOD_CHANNEL="nightly"
export ALGOD_URL=""
export ALGOD_BRANCH=""
export ALGOD_SHA=""
export NETWORK=""
export NETWORK_BOOTSTRAP_URL=""
export NETWORK_GENESIS_FILE=""
export INDEXER_URL="https://github.com/barnjamin/indexer"
export INDEXER_BRANCH="convert-zero-to-nil"
export INDEXER_SHA=""
export INDEXER_DISABLED=""
$ ./sandbox up barnjamin
winder
reviewed
May 4, 2021
winder
reviewed
May 4, 2021
winder
approved these changes
May 4, 2021
|
@barnjamin we have a new reward program, this PR may qualify: |
|
oh nice, ill take a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #144
I wrote no new tests for this, though it probably should have some.
I chose to convert any struct fields that contained GT/LT or GreaterThan/LessThan that were uint64 to *uint64. A 0 value for AlgosLT will never (?) happen in reality but it offended me to leave it out.
I redefined uint64Ptr in one of the test files because exporting it from another one was weird.