Enhancement: Use Sandbox for Testing #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Aug 17, 2022
tzaffi
commented
Aug 17, 2022
tzaffi
commented
Aug 18, 2022
tzaffi
commented
Aug 19, 2022
tzaffi
commented
Aug 19, 2022
tzaffi
commented
Aug 19, 2022
tzaffi
commented
Aug 19, 2022
Comment on lines
+13
to
+24
| harness: | ||
| ./test-harness.sh | ||
|
|
||
| docker-javasdk-build: | ||
| # Build SDK testing environment | ||
| docker build -t java-sdk-testing . | ||
|
|
||
| docker-javasdk-run: | ||
| # Launch SDK testing | ||
| docker run -it --network host java-sdk-testing:latest | ||
|
|
||
| docker-test: | ||
| ./run_integration_tests.sh | ||
| docker-test: harness docker-javasdk-build docker-javasdk-run |
There was a problem hiding this comment.
Breaking up make docker-test into:
- pull down the
harness - build the javasdk docker
- run the javasdk docker (which runs
make unitandmake integration)
tzaffi
commented
Aug 19, 2022
Comment on lines
+1
to
+2
| UNIT_TAGS := "$(subst :, or ,$(shell awk '{print $2}' src/test/unit.tags | paste -s -d: -))" | ||
| INTEGRATION_TAGS := "$(subst :, or ,$(shell awk '{print $2}' src/test/integration.tags | paste -s -d: -))" |
There was a problem hiding this comment.
cucumber tags now reside in:
src/test/integration.tagssrc/test/unit.tags
tzaffi
commented
Aug 19, 2022
tzaffi
commented
Aug 22, 2022
| mvn test -Dtest=com.algorand.algosdk.integration.RunCucumberIntegrationTest -Dcucumber.filter.tags=$(INTEGRATION_TAGS) | ||
|
|
||
| display-all-java-steps: | ||
| find src/test/java/com/algorand/algosdk -name "*.java" | xargs grep "io.cucumber.java.en" 2>/dev/null | grep -v Binary | cut -d: -f1 | sort | uniq | xargs grep -E "@(Given|Then|When)" |
There was a problem hiding this comment.
Command that generates input for Unused Steps Analysis script
michaeldiamant
approved these changes
Aug 22, 2022
ahangsu
added a commit
that referenced
this pull request
Sep 2, 2022
* Ignore copied over txt test resource files (#342) * Github-Actions: Adding pr title and label checks (#339) * Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351) * AVM: Consolidate TEAL and AVM versions (#348) * Testing: Modify cucumber steps to use dev mode network (#350) * DevTools: adding source map decoder (#352) * adding source map decoder * bump to 1.17.0 * Enhancement: Use Sandbox for Testing (#363) * Bugfix: Pass verbosity to the harness and sandbox (#371) * Enhancement: Deprecating use of langspec (#367) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * StateProofs: Add State Proof support. (#360) * Regenerate client. * Implement cucumber response tests. * Implement path tests, update Makefile, update README. * Revert * Add state proof fields to Transaction. * Update README.md * Update src/main/java/com/algorand/algosdk/transaction/Transaction.java * publish results. * Add transaction-root-256 * dummy commit to avoid check pr category * dummy commit to kill previous dummy commit Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by algorand/algorand-sdk-testing#220
...which explains most of the removed steps.
Additional Unused Steps via Unused Steps Analysis Script
according to this spreadsheet
the transaction should still be the sameI get transactions by address onlyI get transactions by address and date@Given("indexer client {int} at {string} port {int} with token {string}")@Given("key registration transaction parameters {int} {int} {int} {string} {string} {string} {int} {int} {int} {string} {string}")@When("I create the payment transaction")@When("I create the key registration transaction")@Then("I can get the transaction by ID")@When("I read a transaction {string} from file {string}")@When("I write the transaction to file")@Then("I do my part")@When("I get recent transactions, limited by {int} transactions")