-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Uint8Arrays public keys for kmd signing #549
Conversation
The user gets the public key from `algosdk.decodeAddress(authAddress)` in the Uint8Array format, and the kmd client can already accept this how it is implemented. So it makes sense to allow this in the types for `signTransactionWithSpecificPublicKey` and `signMultisigTransaction`
Sorry for the late reply. This looks like a good change, so if you can sign the CLA and pass our CI tests, I'll approve it. |
Thanks for the response @jasonpaulos. It looks like the CI is failing because of a hash mismatch when downloading a docker image 🤔. is there a way to retrigger the CI? Maybe it will work if it is tried again |
I've rerun the failed tests, so hopefully it will pass now |
@vividn actually the chrome test is still failing because this branch uses an older version of the chromedriver package. Could you merge the develop branch into here? That should fix it |
Interesting, you're right. I'll try to investigate further |
There was a problem in our develop branch which caused the test failure. Once #564 is merged (and we merge it into develop as well), could you again merge develop into this branch? Tests should pass once that happens |
Sure I can do that. Thanks @jasonpaulos |
@vividn while that would work, we're already far along in the release and I don't want to delay it any longer. This will go out in the next release we make. |
Success 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for your patience! 😅
The user gets the public key from
algosdk.decodeAddress(authAddress)
in the Uint8Array format, and the kmd client can already accept this how it is implemented. So it makes sense to allow this in the types forsignTransactionWithSpecificPublicKey
andsignMultisigTransaction