Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore raw support from upstream #3

Merged
merged 2 commits into from
May 23, 2020
Merged

Conversation

tsachiherman
Copy link
Contributor

Add the support for Raw objects

@algomaxj
Copy link

would be good to get a review from @zeldovich too since he did all of our msgp work

@tsachiherman
Copy link
Contributor Author

would be good to get a review from @zeldovich too since he did all of our msgp work

I tested it and it seems to be working correctly for our use case, but I'll wait to hear from Nickolai as you suggested.

Copy link
Collaborator

@zeldovich zeldovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're planning to use msgp.Raw to implement msgp.Marshaler, you should add Raw.CanMarshalMsg():

https://github.com/algorand/msgp/blob/master/msgp/write.go#L55

and similarly Raw.CanUnmarshalMsg() for msgp.Unmarshaler:

https://github.com/algorand/msgp/blob/master/msgp/read.go#L81

Otherwise, this seems like a reasonable change. I got rid of it as part of a broader removal of unused features from msgp, but this seems like a perfectly fine thing to resuscitate.

@tsachiherman tsachiherman merged commit 058212f into master May 23, 2020
@tsachiherman tsachiherman deleted the tsachi/altrawsupport branch May 23, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants