Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #231 into abi-indexable-types #240

Conversation

michaeldiamant
Copy link
Contributor

Merges #231 into abi-indexable-types.

I provide the PR because the diff in pyteal/__init__.pyi prevents IDE type resolution. And I assume others will run into the same issue.

jasonpaulos and others added 3 commits March 3, 2022 09:21
* Fix build script invocation (algorand#223)

* Regen __init__.pyi

* Reorder CI build steps to change source files before running tests (algorand#225)

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
* Fix build script invocation (algorand#223)

* Bring algorand#225 to master (algorand#227)

* Ignore tests generating TEAL file outputs used for expected comparisons (algorand#228)

* Fix typo in CONTRIBUTING.md (algorand#229)

Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
@michaeldiamant
Copy link
Contributor Author

Note - The build is expected to fail due to lack of support for https://docs.python.org/3/library/typing.html#typing.Literal in Python < 3.8. We're aware of the topic and will address out-of-band to the PR.

@michaeldiamant
Copy link
Contributor Author

Closing - #222 now reflects the change this PR intended to merge in.

@michaeldiamant michaeldiamant deleted the abi-indexable-types branch March 16, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants